perf: optimize text-table by replacing regex with trimEnd#19061
perf: optimize text-table by replacing regex with trimEnd#19061mdjermanovic merged 8 commits intomainfrom
text-table by replacing regex with trimEnd#19061Conversation
✅ Deploy Preview for docs-eslint canceled.
|
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Functional changes LGTM - it's easier to review when they're so close to the original! 🙂
But, something like half the file is dead code from over a decade ago. It feels odd to me to include so much of that in ESLint. Proposal: how about treating this as a fork of text-table and removing the portions that are never used?
|
I have resolved all the comments. Ready for a re-review. |
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
There's some more code I think we can directly remove. But consider this a ✅ otherwise!
mdjermanovic
left a comment
There was a problem hiding this comment.
line:column was right-aligned:
But after this change, it would be left-aligned, and also seem to be breaking the table formatting:
|
@mdjermanovic Good catch! Fixed in 89efc43 |
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving open for @nzakas and @JoshuaKGoldberg to verify.
nzakas
left a comment
There was a problem hiding this comment.
LGTM. Waiting for @JoshuaKGoldberg to verify before merging.
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Looks great to me, thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Performance improvements
What changes did you make? (Give an overview)
Fix #18709
Is there anything you'd like reviewers to focus on?
I disabled some lint rules to avoid unwanted refactors in 3rd party code.