Skip to content

fix: use-isnan doesn't report on SequenceExpressions - #18059

Merged
nzakas merged 7 commits into
eslint:mainfrom
StyleShit:fix/use-isnan-sequence-expression
Feb 6, 2024
Merged

nzakas merged 7 commits into
eslint:mainfrom
StyleShit:fix/use-isnan-sequence-expression

Conversation

@StyleShit

@StyleShit StyleShit commented Jan 31, 2024 •

Copy link
Copy Markdown
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The use-isnan rule didn't report SequenceExpressions, so I've added a short condition to check for that, plus some tests

Closes #18058

@StyleShit
StyleShit requested a review from a team as a code owner January 31, 2024 18:44
@netlify

netlify Bot commented Jan 31, 2024 •

Copy link
Copy Markdown

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 172657c
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65c11178aa2d5d0008cb5c65
😎 Deploy Preview https://deploy-preview-18059--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eslint-github-bot eslint-github-bot Bot added the bug ESLint is working incorrectly label Jan 31, 2024
@nzakas

nzakas commented Jan 31, 2024

Copy link
Copy Markdown
Member

@StyleShit can you please update your description and fill out the pull request template? This is required in every PR. Thanks!

@StyleShit

Copy link
Copy Markdown
Contributor Author

@nzakas Sure, sorry for that (again... 😅)

I'm just used to opening a PR from my local machine without even opening Github, so it doesn't add the template.
Will make sure to use it next time 😄

@nzakas

nzakas commented Jan 31, 2024

Copy link
Copy Markdown
Member

That's what I figured, no worries. :)

@nzakas nzakas added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jan 31, 2024

@nzakas nzakas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Can you also add some examples to the docs?

@StyleShit

Copy link
Copy Markdown
Contributor Author

That's a good idea!
Not sure what/where to put it though, added this for now, but we can probably do better, WDYT?

@amareshsm amareshsm added rule Relates to ESLint's core rules enhancement This change enhances an existing feature of ESLint and removed enhancement This change enhances an existing feature of ESLint labels Feb 1, 2024
Comment thread lib/rules/use-isnan.js Resolved
Comment thread tests/lib/rules/use-isnan.js Resolved

@mdjermanovic mdjermanovic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving this open for @nzakas to verify.

@nzakas nzakas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@eslint-github-bot eslint-github-bot Bot locked and limited conversation to collaborators Aug 5, 2024
@eslint-github-bot eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly contributor pool rule Relates to ESLint's core rules

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Bug: use-isnan doesn't report on SequenceExpressions

4 participants