Updating deprecated docstring Client() class#3426
Merged
lovelydinosaur merged 2 commits intoencode:masterfrom Nov 29, 2024
Merged
Updating deprecated docstring Client() class#3426lovelydinosaur merged 2 commits intoencode:masterfrom
lovelydinosaur merged 2 commits intoencode:masterfrom
Conversation
Update _client.py "proxies" param is missing if passed as keyword argument. Even tough it should be there, since it is mentioned in the docstring as an optional param.
Update _client.py Updating deprecated docstring Client() class. Keyword param "proxies" is no longer used, but it was still "possible" by the docstring of the class. That docstring is now updated to avoid developers on passing deprecated params.
3 tasks
lovelydinosaur
approved these changes
Nov 29, 2024
Contributor
|
Thanks. |
Contributor
Author
|
Great, thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updating deprecated docstring Client() class. Keyword param "proxies" is no longer used and supported, but it was still "optional" by the docstring of the class. That docstring is now updated to avoid developers on passing deprecated params.
Checklist