Merged
Conversation
Removes the gn arg that disabled V8 builtins profile-guided optimization and adds a V8 patch to warn instead of abort when the builtin PGO profile data does not match. Also strips the PGO-related flags from the generated mksnapshot_args so they are not passed through to downstream mksnapshot invocations. Co-authored-by: Sam Attard <sattard@anthropic.com>
Addresses review feedback: the v8_enable_javascript_promise_hooks flag is set to support Node.js async_hooks, not used directly by Electron. Co-authored-by: Sam Attard <sattard@anthropic.com>
3 tasks
MarshallOfSound
approved these changes
Mar 30, 2026
VerteDinde
approved these changes
Mar 30, 2026
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #50416
See that PR for details.
Notes: Enabled profile-guided optimization for V8 builtins in release builds, improving JavaScript builtin performance (Array, String, RegExp, etc.).