chore: cherry-pick 248acd90d9a3 from skia#50234
Merged
VerteDinde merged 3 commits into41-x-yfrom Mar 13, 2026
Merged
Conversation
MarshallOfSound
approved these changes
Mar 12, 2026
ckerr
approved these changes
Mar 12, 2026
|
Release Notes Persisted
|
yuyuyureka
reviewed
Mar 14, 2026
| { "patch_dir": "src/electron/patches/ReactiveObjC", "repo": "src/third_party/squirrel.mac/vendor/ReactiveObjC" }, | ||
| { "patch_dir": "src/electron/patches/webrtc", "repo": "src/third_party/webrtc" }, | ||
| { "patch_dir": "src/electron/patches/reclient-configs", "repo": "src/third_party/engflow-reclient-configs" }, | ||
| { "patch_dir": "src/electron/patches/skia", "repo": "src/third_party/skia/src" }, |
There was a problem hiding this comment.
Shouldn't this be only src/third_party/skia since the patches already contain the src/ prefix and there is no src/src/?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure we are getting the correct atlas for glyph mask format.
Bug: b/491421267
Change-Id: I4eacd46599eca2df8c10a3fc894b9ce890fae1e2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1184076
Commit-Queue: Greg Daniel egdaniel@google.com
Reviewed-by: Michael Ludwig michaelludwig@google.com
(cherry picked from commit 0cab3e4ee34b3bca6ba7df676639d73ffe4b2135)
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1184916
Notes: Backported fix for b/491421267.