feat: Use DIR_ASSETS path to locate resource bundles#47950
Merged
codebytere merged 7 commits into38-x-yfrom Aug 6, 2025
Merged
Conversation
Co-authored-by: Will Anderson <andersonw@dropbox.com>
Co-authored-by: Will Anderson <andersonw@dropbox.com>
Co-authored-by: Will Anderson <andersonw@dropbox.com>
Co-authored-by: Will Anderson <andersonw@dropbox.com>
Co-authored-by: Will Anderson <andersonw@dropbox.com>
…ble on Windows + Linux Co-authored-by: Will Anderson <andersonw@dropbox.com>
Co-authored-by: Will Anderson <andersonw@dropbox.com>
5 tasks
codebytere
approved these changes
Aug 6, 2025
Member
codebytere
left a comment
There was a problem hiding this comment.
Approved by @electron/wg-releases on Aug 6th 2025
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #47439
See that PR for details.
Notes: Internally switched to using
DIR_ASSETSinstead ofDIR_MODULE/DIR_EXEto locate assets and resources, and added "assets" as a key that can be queried viaapp.getPath.