Skip to content

chore: cherry-pick d5b0cb2acffe from v8#50233

Merged
VerteDinde merged 2 commits into41-x-yfrom
cherry-pick/41-x-y/v8/d5b0cb2acffe
Mar 13, 2026
Merged

chore: cherry-pick d5b0cb2acffe from v8#50233
VerteDinde merged 2 commits into41-x-yfrom
cherry-pick/41-x-y/v8/d5b0cb2acffe

Conversation

@VerteDinde
Copy link
Copy Markdown
Member

@VerteDinde VerteDinde commented Mar 12, 2026

[M144 Merge] [maglev] fix CanElideWriteBarrier Smi recording for phis

Recording a Tagged use is not enough for 2 reasons:

  • Tagged uses are sometimes ignored, in particular for loop phis
    where we distinguish in-loop and out-of-loop uses.

  • This Tagged use could only prevent untagging of this specific phi,
    but none of its inputs. So we could have a Smi phi as input to the
    current phi which gets untagged and retagged to a non-Smi, all
    while the current phi doesn't get untagged.

(cherry picked from commit a54bf5cd45e5b119e2afe6019428e81c3d626fb3)

Change-Id: I9b3a2ea339f2c9d81dbb74a44425ba55d8c73871
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7604255
Auto-Submit: Darius Mercadier dmercadier@chromium.org
Reviewed-by: Leszek Swirski leszeks@chromium.org
Commit-Queue: Darius Mercadier dmercadier@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#105444}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7659106
Auto-Submit: Srinivas Sista srinivassista@chromium.org
Reviewed-by: Rezvan Mahdavi Hezaveh rezvan@chromium.org
Commit-Queue: Srinivas Sista srinivassista@chromium.org
Reviewed-by: Deepti Gandluri gdeepti@chromium.org
Owners-Override: Srinivas Sista srinivassista@chromium.org
Cr-Commit-Position: refs/branch-heads/14.4@{#64}
Cr-Branched-From: 80acc26727d5a34e77dabeebe7c9213ec1bd4768-refs/heads/14.4.258@{#1}
Cr-Branched-From: ce7e597e90f6df3fa4b6df224bc613b80c635450-refs/heads/main@{#104020}

Notes: no-notes

@VerteDinde VerteDinde requested a review from a team as a code owner March 12, 2026 23:21
@VerteDinde VerteDinde added semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 41-x-y labels Mar 12, 2026
@VerteDinde VerteDinde enabled auto-merge (squash) March 13, 2026 02:54
@VerteDinde VerteDinde merged commit 42d7f27 into 41-x-y Mar 13, 2026
102 of 106 checks passed
@VerteDinde VerteDinde deleted the cherry-pick/41-x-y/v8/d5b0cb2acffe branch March 13, 2026 03:11
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Mar 13, 2026

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

41-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants