Conversation
Add a "typecheck" script (tsc --noEmit) to package.json and run it in CI before lint and test. This catches TypeScript type errors that esbuild silently ignores during bundling.
5585e1a to
2ae6b74
Compare
truggeri
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
"typecheck": "tsc --noEmit"script topackage.jsonand runs it in CI before lint and test.Since esbuild strips types without checking them, type errors were previously only caught indirectly by
ts-jestduring tests — and only for files covered by tests. This adds explicit type-checking as a CI gate.npm run typecheckpasses cleanly on main.