Switch tsconfig module resolution to bundler#682
Merged
Conversation
jeffwidman
commented
Mar 26, 2026
| "target": "es2022", | ||
| "module": "commonjs", | ||
| "moduleResolution": "node", | ||
| "module": "es2022", |
Member
Author
There was a problem hiding this comment.
Since target will soon change to es2024 (#680), I asked copilot about changing this to es2024 as well... but it said that typescript doesn't support that and es2022 is the latest stable value for this... since we don't want to jump to esnext.
jeffwidman
commented
Mar 26, 2026
| "module": "commonjs", | ||
| "moduleResolution": "node", | ||
| "module": "es2022", | ||
| "moduleResolution": "bundler", |
Member
Author
There was a problem hiding this comment.
I also asked Copilot if these two changes should be separate logical changes, or together, and it said they should go together because the default for bundler is node16 or something... so we need to specify both the resolution and the module to use since we want a non-default.
Changes module from "commonjs" to "es2022" and moduleResolution from "node" to "bundler". This tells TypeScript to resolve imports the way esbuild does, including support for package.json "exports" maps used by newer @actions/* and @octokit/* packages. Since esbuild handles the actual CJS output (--format=cjs), these settings only affect type-checking — the runtime behavior is unchanged.
6c4c100 to
0ea234d
Compare
truggeri
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
modulefrom"commonjs"to"es2022"andmoduleResolutionfrom"node"to"bundler".This tells TypeScript to resolve imports the way esbuild does, including support for
package.json"exports"maps used by newer@actions/*and@octokit/*packages.Since esbuild handles the actual CJS output (
--format=cjs), these settings only affect type-checking — the runtime behavior is unchanged.All 49 tests pass.
tsc --noEmitclean.