Add --legal-comments=none to esbuild build commands#679
Merged
Conversation
eb0c091 to
38b0e8d
Compare
Strip license/copyright banners from bundled dependencies. These comments inflate the checked-in dist/ file and diffs without adding value (licenses are tracked in node_modules and package-lock.json).
38b0e8d to
355e41f
Compare
truggeri
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #676.
Adds
--legal-comments=noneto both thebuildanddry-runesbuild commands to strip license/copyright banners from the bundled output. These comments inflate the checked-indist/file and diffs without adding value — licenses are already tracked innode_modulesandpackage-lock.json.