Switch build tooling from ncc to esbuild#676
Merged
jeffwidman merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
Replace @vercel/ncc and ts-node with esbuild for bundling. This prepares the project for ESM-only dependencies (@actions/core 3.x and @actions/github 9.x use ESM-only exports). Changes: - Build script: ncc build → esbuild --bundle --platform=node --format=cjs - Dry-run script: ts-node → esbuild bundle + node - Jest: add ESM transform, transformIgnorePatterns, custom resolver - tsconfig: add skipLibCheck for library subpath exports compatibility - Remove @vercel/ncc and ts-node dev dependencies
This was referenced Mar 26, 2026
jeffwidman
approved these changes
Mar 26, 2026
Member
jeffwidman
left a comment
There was a problem hiding this comment.
I didn't understand a lot of these flags/configs, but I walked through it with copilot and they make sense to me
| .idea/ | ||
| .vscode/ No newline at end of file | ||
| .vscode/ | ||
| dist/dry-run.js No newline at end of file |
This was referenced Mar 26, 2026
jeffwidman
reviewed
Mar 26, 2026
| "noImplicitAny": false, | ||
| "esModuleInterop": true | ||
| "esModuleInterop": true, | ||
| "skipLibCheck": true |
Member
There was a problem hiding this comment.
We can drop this with a few other changes:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 1 of a larger update, see #673 .
Replace
@vercel/nccandts-nodewithesbuildfor bundling. This prepares the project for ESM-only dependencies (@actions/core3.x and@actions/github9.x use ESM-only exports that ncc cannot resolve).Changes
ncc build→esbuild --bundle --platform=node --format=cjsts-node→ esbuild bundle + node.jsfiles),transformIgnorePatternsto allow transforming@actions/*and@octokit/*packages, and a custom resolver (jest-resolver.js) that adds theimportcondition for@actions/*packagesskipLibCheck: truefor library subpath exports compatibility@vercel/ncc,ts-nodedev dependenciesesbuilddev dependency