Conversation
mattieruth
approved these changes
Mar 27, 2024
mattieruth
left a comment
There was a problem hiding this comment.
common sense tells me this change is good 👍
mattieruth
reviewed
Mar 27, 2024
| if (r.id().equals(senderId)) { | ||
| targetSender = r; | ||
| RtpSender targetSender = null; | ||
| for (RtpSender s : this.peerConnection.getSenders()) { |
There was a problem hiding this comment.
one question: here you added this. -- Do we need to change that in receiverGetStats() too? or was the addition of this somehow not necessary?
Author
There was a problem hiding this comment.
this keyword is used to refer to the current instance of the class in which it appears. But it is not mandatory, it is just to make it more explicit.
Author
|
Thank you for the review @mattieruth 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing stats for Android