Add a retry mechanism for fetching setup executable#26
Merged
jon-turney merged 3 commits intocygwin:masterfrom Apr 9, 2025
Merged
Add a retry mechanism for fetching setup executable#26jon-turney merged 3 commits intocygwin:masterfrom
jon-turney merged 3 commits intocygwin:masterfrom
Conversation
Contributor
|
10 seconds between retries seems a bit long to me. Maybe 2 or 3 seconds instead? The rest looks good to me. |
vszakats
reviewed
Mar 26, 2025
Contributor
|
While repeatedly running CI tests for #27, I encountered more than a few spurious |
Member
Author
|
Yeah, unfortunately sourceware is getting hammered by LLM scraperbots at the moment |
8cb59b1 to
e624e5d
Compare
Also, don't use a naked catch, so we don't trap sytnax or usage errors etc., only network failures.
|
Thanks @jon-turney! |
vszakats
added a commit
to curl/curl
that referenced
this pull request
Apr 12, 2025
- to benefit from the new download retry mechanism. cygwin/cygwin-install-action#26 - to use a new setting that not only moves the Cygwin install target directory to the faster `D:` drive, but also the package download directory. Expecting a little performance improvement from this for the Cygwin install step. cygwin/cygwin-install-action@d3a7464 cygwin/cygwin-install-action#27 Closes #17040
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
- to benefit from the new download retry mechanism. cygwin/cygwin-install-action#26 - to use a new setting that not only moves the Cygwin install target directory to the faster `D:` drive, but also the package download directory. Expecting a little performance improvement from this for the Cygwin install step. cygwin/cygwin-install-action@d3a7464 cygwin/cygwin-install-action#27 Closes curl#17040
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
- to benefit from the new download retry mechanism. cygwin/cygwin-install-action#26 - to use a new setting that not only moves the Cygwin install target directory to the faster `D:` drive, but also the package download directory. Expecting a little performance improvement from this for the Cygwin install step. cygwin/cygwin-install-action@d3a7464 cygwin/cygwin-install-action#27 Closes curl#17040
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9