Avoid scanning anonymous classes#3150
Merged
mpkorstanje merged 7 commits intomainfrom Jan 26, 2026
Merged
Conversation
1 task
mpkorstanje
added a commit
that referenced
this pull request
Jan 28, 2026
This reverts commit 3f27ff4
This was referenced Jan 28, 2026
mpkorstanje
added a commit
that referenced
this pull request
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
When scanning classes, we avoid scanning anonymous classes, because they cannot contain cucumber steps and hooks.
⚡️ What's your motivation?
Contributes to #3141.
Anonymous classes are non-public classes so their methods will not be scanned by the
MethodScanner, but the class will still be loaded. By avoiding scanning the anonymous classes earlier in theClasspathScanner, we avoid loading the class. Well, the class may be loaded by other part of the application, but at least this will not be Cucumber's fault.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
N/A
📋 Checklist: