ref: Tidy up types and remove string coercion#1536
Merged
thomasrockhu-codecov merged 3 commits intomainfrom Aug 12, 2024
Merged
ref: Tidy up types and remove string coercion#1536thomasrockhu-codecov merged 3 commits intomainfrom
thomasrockhu-codecov merged 3 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1536 +/- ##
==========================================
+ Coverage 91.66% 92.92% +1.25%
==========================================
Files 5 5
Lines 324 325 +1
Branches 86 77 -9
==========================================
+ Hits 297 302 +5
+ Misses 27 21 -6
- Partials 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swatinem
approved these changes
Aug 9, 2024
Comment on lines
+36
to
+38
| ['pull_request', 'pull_request_target'].every( | ||
| (event) => event !== context.eventName, | ||
| ) |
There was a problem hiding this comment.
Suggested change
| ['pull_request', 'pull_request_target'].every( | |
| (event) => event !== context.eventName, | |
| ) | |
| !['pull_request', 'pull_request_target'].includes(context.eventName) |
similar to below
Author
There was a problem hiding this comment.
Ahhh yea that would be better ... i spent a hot minute looking at MDN docs trying to figure out the "smart" way ... and all i needed was a ! 🤦
thomasrockhu-codecov
approved these changes
Aug 12, 2024
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in a package to give the correct types for GH payload events, as well this PR removes redundant string coercion that's not needed.