Issue #18673: organised recipes by Anushreebasics · Pull Request #18791 · checkstyle/checkstyle

Anushreebasics · 2026-01-29T14:10:14Z

Summary:

Grouped and organized the OpenRewrite recipes by:

Adding a section for composite recipes (e.g., CheckstyleAutoFix, CommonStaticAnalysis).
Separating individual recipes and grouping them after the composite ones.

Moved the tech.picnic.errorprone.refasterrules recipes out of the static analysis composite group and listed them individually.

Added comments to clarify composite and individual recipe sections.

Reformatted the YAML for clarity and maintainability (e.g., multi-line description, section headers).

Removed duplicate and misplaced recipes from the static analysis composite group.

These changes align the file structure and grouping with the OpenRewrite website. No logic or recipe content was changed—only the grouping, order, and formatting.

@romani please review

Pankraz76 · 2026-01-29T16:42:14Z

+  - tech.picnic.errorprone.refasterrules.StreamRulesRecipes
+  - tech.picnic.errorprone.refasterrules.TimeRulesRecipes
+---
+


Suggested change

Pankraz76 · 2026-01-29T16:43:20Z

kindly consider to pull this afterwards:

Pull #18756: Add CommonStaticAnalysis #18756

Anushreebasics · 2026-01-29T16:52:51Z

@Pankraz76 why have you changed other files apart from rewrite.yml?

romani

Items

Pankraz76 · 2026-01-30T10:45:03Z

@Pankraz76 why have you changed other files apart from rewrite.yml?

because i have added all the recipes it seems you just doing a reorg.

romani · 2026-01-30T10:47:35Z

@Anushreebasics , please resovle conflict, we did split.
but your update still required.

Pankraz76 · 2026-01-30T10:59:26Z

how can the pipeline be red? you trying to patch but actually you just mimic the dryRun feature of rewrite but going for the feature envy reimplementing rewrite. This makes no sense and is not how its supposed to be done @romani

as seen here....

Pull #18746: Add failOnDryRunResults to fix rewrite feature envy #18746

romani · 2026-01-30T11:15:09Z

@Anushreebasics , can you please always have single commit in PRs.
Always, always squash all in one commit.

Pankraz76 · 2026-01-30T11:18:23Z

Always, always squash all in one commit.

had same idea. you can squash merge as well. consider adding the squash hint to readme. also then add simple CI job to fail CI if more then 1 commit in total right, like the no merge commits stuff count == 1 is very simple condition to check and fail.

Pankraz76 · 2026-01-30T11:29:59Z

git reset --soft $(git merge-base master HEAD)

romani

items:

romani · 2026-01-30T11:40:35Z

+  - org.openrewrite.staticanalysis.CommonStaticAnalysis
+  # individual recipes
+  - org.openrewrite.staticanalysis.CommonStaticAnalysis


???
remove from individual

romani · 2026-01-30T11:43:12Z

+  # - org.openrewrite.staticanalysis.ChainStringBuilderAppendCalls
+  # - org.openrewrite.staticanalysis.ClassUnnecessaryModifier
+  # - org.openrewrite.staticanalysis.CloseResource
+  # - org.openrewrite.staticanalysis.CommonStaticAnalysis


???? there is not such

and no CloseResource.

just copy
paste and comment out what was not activated before to avoid violations.

romani · 2026-01-30T11:44:32Z

+description: |
+  Resolve common static analysis issues (also known as SAST issues).
+recipeList:
+  # The following recipes are available but not currently enabled. Uncomment to enable as needed.


please create new issue and put in comment "until #xxxx "
we will investigate each rules separately to make decision on permanent suppression or actually apply.

…kstyle#18673 checkstyle#18791

Pankraz76 · 2026-01-30T12:11:27Z

kindly consider enabler:

Pull #18795: Dedicate rewrite recipes #18795

…kstyle#18673 checkstyle#18791

Copilot

Pull request overview

Reorganizes the OpenRewrite recipe catalog/configuration to group composite recipes separately from individual recipes and aligns sections with the OpenRewrite static analysis recipe listing.

Changes:

Restructured config/rewrite.yml recipe groupings (composite vs individual), added section comments, and reformatted descriptions.
Added SAST to the spellchecker whitelist.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

File	Description
config/rewrite.yml	Reorders/regroups OpenRewrite recipes and introduces/renames recipe definitions and section headers.
config/jsoref-spellchecker/whitelist.words	Adds `SAST` to the allowed word list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-03T09:14:16Z

+  - org.openrewrite.staticanalysis.CommonStaticAnalysis
+  # individual recipes


recipeList includes org.openrewrite.staticanalysis.CommonStaticAnalysis twice and also repeats the # individual recipes section header, which will cause the same composite recipe to run multiple times. Remove the duplicate entry/header so each recipe is listed only once.

Suggested change

- org.openrewrite.staticanalysis.CommonStaticAnalysis

# individual recipes

Copilot · 2026-02-03T09:14:17Z

+name: org.openrewrite.staticanalysis.CommonStaticAnalysis
+displayName: Common static analysis issues
+description: |
+  Resolve common static analysis issues (also known as SAST issues).
 recipeList:
  - tech.picnic.errorprone.refasterrules.BigDecimalRulesRecipes
  - tech.picnic.errorprone.refasterrules.CharSequenceRulesRecipes


This recipe is named org.openrewrite.staticanalysis.CommonStaticAnalysis, but it only contains tech.picnic.errorprone.refasterrules.* entries. Reusing the OpenRewrite built-in recipe ID here is likely to shadow/override the upstream recipe and also makes the name/description misleading. Rename this recipe back to a Checkstyle-owned ID (e.g., org.checkstyle.RefasterRules) or remove it and reference the upstream recipe directly.

Copilot · 2026-02-03T09:14:17Z

 type: specs.openrewrite.org/v1beta/recipe
-name: org.checkstyle.StaticAnalysis
-description: OpenRewrite standard fixes.
+name: org.openrewrite.staticanalysis.CommonStaticAnalysis
+displayName: Common static analysis issues
+description: |
+  Resolve common static analysis issues (also known as SAST issues).


org.openrewrite.staticanalysis.CommonStaticAnalysis is defined a second time later in the same YAML file. Duplicate recipe names in a recipe catalog are ambiguous and can lead to one definition overriding the other (or load failures). Ensure each recipe name is unique (e.g., keep only one definition for this ID, and give other groups a different name).

Copilot · 2026-02-03T09:14:18Z

+type: specs.openrewrite.org/v1beta/recipe
+name: org.checkstyle.AutoFixesPart2
+displayName: Auto Fixes Part 2
+description: ErrorProne Refaster rules.
+recipeList:


org.checkstyle.AutoFixesPart2 is defined here but is not referenced by any other recipe in this file (and org.checkstyle.AllAutoFixes in particular still references org.checkstyle.RefasterRules/org.checkstyle.StaticAnalysis). Either wire this new recipe into the active recipe graph or remove it to avoid dead/unused configuration.

Copilot · 2026-02-03T09:14:18Z

+  # current maintainer don't "like" orElseThrow() as better form of get()
+  # - tech.picnic.errorprone.refasterrules.OptionalRulesRecipes


Grammar in this comment is incorrect: "current maintainer don't" should be "current maintainer doesn't".

org.openrewrite.staticanalysis.CommonStaticAnalysis is defined a second time later in the same YAML file. Duplicate recipe names in a recipe catalog are ambiguous and can lead to one definition overriding the other (or load failures). Ensure each recipe name is unique (e.g., keep only one definition for this ID, and give other groups a different name).

Anushreebasics · 2026-02-04T01:11:13Z

@romani please review

…documentation with Example3 showing Apache license header matching

Pankraz76 · 2026-02-04T19:48:36Z

+  - org.openrewrite.java.format.PadEmptyForLoopComponents
+  - org.openrewrite.java.format.RemoveTrailingWhitespace
+  # until https://github.com/checkstyle/checkstyle/issues/18789
+  # - org.openrewrite.java.migrate.UpgradeToJava21


Issue #18789: Activate Java 21 migration recipes in OpenRewrite CI #18794

org.openrewrite.java.migrate.UpgradeToJava21

romani

Items

romani · 2026-02-04T21:11:25Z

+# Composite group for static analysis, as on openrewrite website
+---
+type: specs.openrewrite.org/v1beta/recipe
+name: org.openrewrite.staticanalysis.CommonStaticAnalysis


Please use this group in most top list , under "composite recipes"

@Anushreebasics , I expect simple update to make copy from web and disablement of what was not activated before.
Do not listen to @Pankraz76 , and simply try to archive simple goal. You have chance to merged quicker than his PRs

Anushreebasics · 2026-02-05T08:21:17Z

@romani please review

Anushreebasics · 2026-02-09T08:52:26Z

@romani please review

romani · 2026-02-17T03:42:44Z

CI is red, please fix

Anushreebasics · 2026-02-17T07:25:50Z

@romani please review

romani · 2026-02-17T16:49:08Z

Expected update was like #18953

Anushreebasics force-pushed the openrewrite branch 2 times, most recently from cda343e to 5787beb Compare January 29, 2026 14:40

Pankraz76 reviewed Jan 29, 2026

View reviewed changes

Anushreebasics force-pushed the openrewrite branch 2 times, most recently from 13b3282 to c10440b Compare January 29, 2026 16:56

romani requested changes Jan 30, 2026

View reviewed changes

Comment thread config/rewrite.yml Outdated

Anushreebasics force-pushed the openrewrite branch from 4153624 to 76218ec Compare January 30, 2026 11:31

romani requested changes Jan 30, 2026

View reviewed changes

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026

Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…

d853da4

…kstyle#18673 checkstyle#18791

Pankraz76 mentioned this pull request Jan 30, 2026

Pull #18795: Dedicate rewrite recipes #18795

Merged

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026

Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…

fec1bab

…kstyle#18673 checkstyle#18791

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026

Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…

ce3831f

…kstyle#18673 checkstyle#18791

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026

Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…

c4a9fa9

…kstyle#18673 checkstyle#18791

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026

Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…

9f7f423

…kstyle#18673 checkstyle#18791

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026

Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…

65e2254

…kstyle#18673 checkstyle#18791

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026

Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…

a9d4a5a

…kstyle#18673 checkstyle#18791

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026

Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…

e9b341b

…kstyle#18673 checkstyle#18791

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026

Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…

96caae6

…kstyle#18673 checkstyle#18791

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026

Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…

e4c63f8

…kstyle#18673 checkstyle#18791

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026

Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…

9848cdd

…kstyle#18673 checkstyle#18791

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 30, 2026

Pull checkstyle#18795: Dedicate rewrite recipes checkstyle#18794 chec…

996222b

…kstyle#18673 checkstyle#18791

Copilot AI reviewed Feb 3, 2026

View reviewed changes

Anushreebasics force-pushed the openrewrite branch 4 times, most recently from 945802c to 0195a9c Compare February 3, 2026 10:06

Anushreebasics added a commit to Anushreebasics/checkstyle that referenced this pull request Feb 4, 2026

Fix PR checkstyle#18791 review comment: Update MultiFileRegexpHeader …

1d7e51c

…documentation with Example3 showing Apache license header matching

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 4, 2026

Pull checkstyle#18819: Add git-check-single-commit checkstyle#18791

314bc61

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 4, 2026

Pull checkstyle#18819: Add git-check-single-commit checkstyle#18791

a0ff107

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 4, 2026

Pull checkstyle#18819: Add git-check-single-commit checkstyle#18791

07874fb

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 4, 2026

Pull checkstyle#18819: Add git-check-single-commit checkstyle#18791

a716930

Pankraz76 suggested changes Feb 4, 2026

View reviewed changes

romani pushed a commit that referenced this pull request Feb 4, 2026

Pull #18819: Add git-check-single-commit #18791

401736b

github-actions Bot modified the milestones: 13.1.0, 13.2.0 Feb 4, 2026

romani requested changes Feb 4, 2026

View reviewed changes

Anushreebasics force-pushed the openrewrite branch 3 times, most recently from 106319a to 3c0e858 Compare February 5, 2026 08:16

Anushreebasics force-pushed the openrewrite branch 2 times, most recently from 792232c to 2c45a8b Compare February 5, 2026 12:57

Anushreebasics force-pushed the openrewrite branch from 2c45a8b to c73187d Compare February 17, 2026 06:06

Issue checkstyle#18673: organised recipes

76a955f

Anushreebasics force-pushed the openrewrite branch from c73187d to 76a955f Compare February 17, 2026 07:13

romani closed this Feb 17, 2026

		- org.openrewrite.staticanalysis.CommonStaticAnalysis
		# individual recipes

		# current maintainer don't "like" orElseThrow() as better form of get()
		# - tech.picnic.errorprone.refasterrules.OptionalRulesRecipes

Uh oh!

Conversation

Anushreebasics commented Jan 29, 2026

Summary:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pankraz76 commented Jan 29, 2026

Uh oh!

Anushreebasics commented Jan 29, 2026

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pankraz76 commented Jan 30, 2026

Uh oh!

romani commented Jan 30, 2026

Uh oh!

Pankraz76 commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani commented Jan 30, 2026

Uh oh!

Pankraz76 commented Jan 30, 2026

Uh oh!

Pankraz76 commented Jan 30, 2026

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

romani Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pankraz76 commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Anushreebasics commented Feb 4, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Pankraz76 commented Jan 30, 2026 •

edited

Loading

romani Jan 30, 2026 •

edited

Loading