Skip to content

Fix confusing 'Question-2' prompt label when using external editor - #1857

Merged
Andarist merged 5 commits into
changesets:mainfrom
mixelburg:fix/changeset-summary-prompt-label
Mar 2, 2026
Merged

Andarist merged 5 commits into
changesets:mainfrom
mixelburg:fix/changeset-summary-prompt-label

Conversation

@mixelburg

Copy link
Copy Markdown
Contributor

Fixes #1763

When a user opens the external editor to write a multiline summary and then closes it (with an empty result), the fallback prompt displayed as Question-2 because askQuestion was called with an empty string message. The enquirer library uses the internal question name as the display label when the message is empty, resulting in the cryptic "Question-2 ·" prompt.

Changes:

  • Pass "Summary" as the message to the post-editor fallback prompt
  • Replace the multiline error message (which also rendered poorly as a prompt label) with a clear single-line message: "A summary is required! Please enter a summary"

@changeset-bot

changeset-bot Bot commented Feb 25, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a3e1897

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Feb 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.81%. Comparing base (e462d89) to head (a3e1897).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1857      +/-   ##
==========================================
- Coverage   81.86%   81.81%   -0.06%     
==========================================
  Files          55       55              
  Lines        2360     2364       +4     
  Branches      706      708       +2     
==========================================
+ Hits         1932     1934       +2     
- Misses        423      425       +2     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Andarist
Andarist enabled auto-merge March 2, 2026 11:46
@Andarist
Andarist added this pull request to the merge queue Mar 2, 2026
Merged via the queue into changesets:main with commit 2a73025 Mar 2, 2026
5 of 6 checks passed
@github-actions github-actions Bot mentioned this pull request Mar 2, 2026
nnecec pushed a commit to nnecec/changesets-docs that referenced this pull request Apr 16, 2026
…hangesets#1857)

* Fix confusing 'Question-2' prompt label when using external editor (changesets#1763)

* style: apply prettier formatting (trailing commas)

* ci: trigger recheck after prettier fix

* fmt

* changeset

---------

Co-authored-by: Maks Pikov <mixelburg@users.noreply.github.com>
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing "Question-2" prompt label when using external editor - should be "Changelog summary" or "Title"

2 participants