Skip to content

Use custom errors when exiting add command due to missing tool - #1489

Merged
Andarist merged 2 commits into
changesets:mainfrom
marcalexiei:feat/add-error-no-pkg
Oct 9, 2024
Merged

Andarist merged 2 commits into
changesets:mainfrom
marcalexiei:feat/add-error-no-pkg

Conversation

@marcalexiei

Copy link
Copy Markdown
Contributor

Followup of #1466 (comment)

In add command, use ExitError from @changesets/errors instead of standard Error when there are no packages.

@changeset-bot

changeset-bot Bot commented Oct 8, 2024 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 00e9993

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Oct 8, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (7ccb22e) to head (00e9993).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/cli/src/commands/add/index.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1489      +/-   ##
==========================================
- Coverage   81.02%   81.00%   -0.02%     
==========================================
  Files          54       54              
  Lines        2213     2216       +3     
  Branches      654      656       +2     
==========================================
+ Hits         1793     1795       +2     
- Misses        416      417       +1     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andarist

Andarist commented Oct 9, 2024

Copy link
Copy Markdown
Member

Could you add a changeset to this PR?

@marcalexiei
marcalexiei force-pushed the feat/add-error-no-pkg branch from 7cc0c44 to 00e9993 Compare October 9, 2024 10:59
@Andarist
Andarist merged commit 7bf751c into changesets:main Oct 9, 2024
@github-actions github-actions Bot mentioned this pull request Oct 9, 2024
@marcalexiei
marcalexiei deleted the feat/add-error-no-pkg branch October 9, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants