Repository navigation
feat: opt out of prettier - #1453
Conversation
🦋 Changeset detectedLatest commit: 985085f The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1453 +/- ##
==========================================
- Coverage 81.00% 80.94% -0.06%
==========================================
Files 54 54
Lines 2232 2241 +9
Branches 659 674 +15
==========================================
+ Hits 1808 1814 +6
- Misses 420 422 +2
- Partials 4 5 +1 ☔ View full report in Codecov by Sentry. |
|
Thank you, @Andarist :D |
| } | ||
| } | ||
|
|
||
| if (json.prettier !== undefined) { |
There was a problem hiding this comment.
@Andarist @bennypowers should this check also include boolean since that is a valid value as well?
There was a problem hiding this comment.
Currently getting
error The `prettier` option is set as false when the only valid values are undefined or a boolean
when setting the config option as false as a result of the above
There was a problem hiding this comment.
I have the same issue here: https://github.com/patternfly/patternfly-elements/actions/runs/13392464424/job/37403199631
Fixes #1452
What I did
add a config flag:add a config flagformatChangesetsWithPrettier(default: true)prettier(default: true)add a cli flag:--noFormatChangesetsWithPrettierwriteChangesetsfrom the cli## Notes to reviewersSee changesets/action#397