Refactor gradle plugin so that tasks can be constructed independently#478
Merged
edward3h merged 8 commits intocasid:mainfrom Nov 21, 2025
Merged
Refactor gradle plugin so that tasks can be constructed independently#478edward3h merged 8 commits intocasid:mainfrom
edward3h merged 8 commits intocasid:mainfrom
Conversation
… of the extension.
Collaborator
Author
|
I should have done a clean and rerun tests before I committed :) |
Collaborator
Author
|
I pushed my implementation of a workaround, to make sure checks pass. This still needs some code comments to explain, and documentation updates. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
=========================================
Coverage 91.17% 91.17%
Complexity 1223 1223
=========================================
Files 76 76
Lines 3174 3174
Branches 492 492
=========================================
Hits 2894 2894
Misses 169 169
Partials 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add independent properties to the task classes, and modify how they get "wired" with extension properties. New test case "jte-runtime-cp-test-gradle-newtask" demonstrates how a task can be created.
I also tried out changing
Property<Path>toDirectoryPropertyandProperty<String[]>toListProperty<String>, but I concluded this is not possible without breaking existing users of the plugin. Perhaps something to add if we make a new major version.