Skip to content

ci: drop node.js 14.x and 16.x testing#536

Merged
ddzz merged 3 commits intoeslint-community:mainfrom
MikeMcC399:remove/node-14-and-16-in-ci
Oct 23, 2024
Merged

ci: drop node.js 14.x and 16.x testing#536
ddzz merged 3 commits intoeslint-community:mainfrom
MikeMcC399:remove/node-14-and-16-in-ci

Conversation

@MikeMcC399
Copy link
Copy Markdown
Contributor

@MikeMcC399 MikeMcC399 commented Oct 22, 2024

Issue

  • Node.js 14.x and 16.x reached Node.js End-of-life more than one year ago and so are unsupported by Node.js.
  • To lint TypeScript in a flat configuration, a minimum @typescript-eslint/eslint-plugin@7.0.0 is required, which in turn requires Node.js ^18.18.0. This rules out Node.js 14.x and 16.x.

Change

@MikeMcC399 MikeMcC399 mentioned this pull request Oct 22, 2024
Closed
@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 22, 2024 11:36
@ddzz
Copy link
Copy Markdown
Contributor

ddzz commented Oct 22, 2024

We should remove 14 and 16 from the engines in the package.json as well.

@MikeMcC399

This comment was marked as outdated.

Sign in to view
@ddzz ddzz requested a review from bmish October 22, 2024 12:20
@ddzz
Copy link
Copy Markdown
Contributor

ddzz commented Oct 22, 2024

@bmish Can you review this PR and its related issues when you have a moment?

@MikeMcC399
Copy link
Copy Markdown
Contributor Author

MikeMcC399 commented Oct 22, 2024 •
edited
Loading

I was originally planning to delay modifying engines until the repo is compatible with ESLint v9, then change the prerequisites of eslint and engines together. I guess the order does not matter too much so long as no new version is released. Modifying engines would be a breaking change anyway.

@MikeMcC399 MikeMcC399 mentioned this pull request Oct 22, 2024
Merged
@MikeMcC399 MikeMcC399 mentioned this pull request Oct 23, 2024
Merged
@ddzz
Copy link
Copy Markdown
Contributor

ddzz commented Oct 23, 2024

@bmish is MIA so I'll approve and merge this. We should add Node 20.x to the matrix in another PR. Thanks for all your work in this repo!

@ddzz ddzz merged commit f108ee1 into eslint-community:main Oct 23, 2024
@MikeMcC399
Copy link
Copy Markdown
Contributor Author

MikeMcC399 commented Oct 23, 2024

@ddzz

@bmish is MIA so I'll approve and merge this. We should add Node 20.x to the matrix in another PR. Thanks for all your work in this repo!

Thank you! This makes it cleaner for the follow-on PRs. I'm happy to work on this knowing you are there to review and merge. 🙂 I don't think we need @bmish at this time. He may still be traveling.

@MikeMcC399 MikeMcC399 deleted the remove/node-14-and-16-in-ci branch October 23, 2024 13:33
@MikeMcC399
Copy link
Copy Markdown
Contributor Author

MikeMcC399 commented Oct 23, 2024 •
edited
Loading

@ddzz

We should add Node 20.x to the matrix in another PR.

Agreed, however the workflow is not yet compatible with Node.js >= 20 (otherwise I would have already added it). I am however planning to look at this.

This was referenced Oct 29, 2024
Closed
Closed
@bmish bmish mentioned this pull request Dec 6, 2024
Merged
@bmish bmish added the internal label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmish bmish Awaiting requested review from bmish

1 more reviewer

@ddzz ddzz ddzz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop Node.js 14.x and 16.x testing in CI

3 participants

@MikeMcC399 @ddzz @bmish