Skip to content

chore: align parser options struct name#9332

Merged
dyc3 merged 2 commits intobiomejs:mainfrom
Netail:chore/align-parser-options-struct
Mar 4, 2026
Merged

chore: align parser options struct name#9332
dyc3 merged 2 commits intobiomejs:mainfrom
Netail:chore/align-parser-options-struct

Conversation

@Netail
Copy link
Copy Markdown
Member

@Netail Netail commented Mar 4, 2026 •
edited
Loading

Summary

Align HTML & Markdown struct name with the others

Test Plan

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 4, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 42975da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-HTML Language: HTML and super languages labels Mar 4, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 4, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fa72c699-6e1b-44ac-ae81-3f45e75377e8

📥 Commits

Reviewing files that changed from the base of the PR and between 86fbc70 and 42975da.

📒 Files selected for processing (23)
  • .claude/skills/biome-developer/SKILL.md
  • .claude/skills/testing-codegen/SKILL.md
  • crates/biome_html_analyze/benches/html_analyzer.rs
  • crates/biome_html_formatter/benches/html_formatter.rs
  • crates/biome_html_formatter/tests/language.rs
  • crates/biome_html_formatter/tests/quick_test.rs
  • crates/biome_html_parser/benches/html_parser.rs
  • crates/biome_html_parser/src/lib.rs
  • crates/biome_html_parser/src/parser.rs
  • crates/biome_html_parser/tests/quick_test.rs
  • crates/biome_html_parser/tests/spec_test.rs
  • crates/biome_html_parser/tests/spec_tests.rs
  • crates/biome_html_syntax/src/element_ext.rs
  • crates/biome_markdown_parser/src/lib.rs
  • crates/biome_markdown_parser/src/link_reference.rs
  • crates/biome_markdown_parser/src/parser.rs
  • crates/biome_markdown_parser/src/syntax/list.rs
  • crates/biome_markdown_parser/src/syntax/quote.rs
  • crates/biome_service/src/file_handlers/html.rs
  • crates/biome_service/src/file_handlers/markdown.rs
  • crates/biome_service/src/settings.rs
  • crates/biome_service/src/workspace/document/services/embedded_value_references.rs
  • xtask/rules_check/src/lib.rs

Walkthrough

This pull request systematically renames parser options types across the codebase to follow a consistent naming convention. HtmlParseOptions is renamed to HtmlParserOptions throughout the HTML parser crate and its dependents, whilst MarkdownParseOptions is renamed to MarkdownParserOptions in the Markdown parser. The changes propagate through public API exports, function signatures, imports, and test usage across multiple crates, including service handlers, benchmarks, and documentation examples.

Possibly related PRs

Suggested reviewers

  • ematipico
  • siketyan
  • dyc3
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarises the main change: renaming parser options structs (HtmlParseOptions/MarkdownParseOptions to HtmlParserOptions/MarkdownParserOptions) to align naming conventions.
Description check ✅ Passed The description clearly relates to the changeset, stating the objective to align HTML and Markdown struct names with others like Json and Css.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 4, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 64 untouched benchmarks
⏩ 152 skipped benchmarks1

Comparing Netail:chore/align-parser-options-struct (42975da) with main (86fbc70)

Open in CodSpeed

Footnotes

  1. 152 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Netail Netail requested review from a team March 4, 2026 22:35
@dyc3 dyc3 merged commit 3064906 into biomejs:main Mar 4, 2026
21 checks passed
@Netail Netail deleted the chore/align-parser-options-struct branch March 4, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees

No one assigned

Labels

A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-HTML Language: HTML and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Netail @dyc3