Skip to content

chore: extra rule source#9294

Merged
Netail merged 1 commit intobiomejs:mainfrom
Netail:fix/rule-reference
Mar 2, 2026
Merged

chore: extra rule source#9294
Netail merged 1 commit intobiomejs:mainfrom
Netail:fix/rule-reference

Conversation

@Netail
Copy link
Copy Markdown
Member

@Netail Netail commented Mar 2, 2026

Summary

Missing import source ref

Test Plan

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 2, 2026

🦋 Changeset detected

Latest commit: cb16839

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Mar 2, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be6844e and cb16839.

📒 Files selected for processing (2)
  • .changeset/brown-boats-sip.md
  • crates/biome_js_analyze/src/assist/source/organize_imports.rs

Walkthrough

This PR introduces a changeset documenting a patch release and extends the OrganizeImports rule to include an additional ESLint rule source reference. The change adds RuleSource::EslintImport("order").inspired() to the rule's sources array, allowing the biome migrate eslint command to better detect and map ESLint import-ordering rules during configuration migration.

Possibly related PRs

Suggested labels

A-CLI, A-Linter, L-JavaScript

Suggested reviewers

  • ematipico
  • siketyan
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: extra rule source' directly relates to the changeset, which adds an extra ESLint rule source reference (RuleSource::EslintImport) to the OrganizeImports rule.
Description check ✅ Passed The description 'Missing import source ref' is related to the changeset, which adds a missing ESLint rule source reference for the organize imports functionality.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Comment @coderabbitai help to get the list of available commands and usage tips.

@Netail Netail merged commit 1805c8f into biomejs:main Mar 2, 2026
17 checks passed
@Netail Netail deleted the fix/rule-reference branch March 2, 2026 09:50
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 2, 2026

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 156 skipped benchmarks1

Comparing Netail:fix/rule-reference (cb16839) with main (e43e730)2

Open in CodSpeed

Footnotes

  1. 156 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (be6844e) during the generation of this report, so e43e730 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@github-actions github-actions Bot mentioned this pull request Mar 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Netail @ematipico