Fix uwsgi incomplete header error with async workers#3554
Merged
Conversation
The _read_exact method was calling unreader.read() without a size parameter, which only reads one chunk at a time. With gevent/gthread workers, this could return incomplete data before the full header arrived. Use unreader.read(size) which has proper retry logic built-in to read the exact number of bytes requested. Fixes #3552
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3552
Use
unreader.read(size)instead ofunreader.read()to properly read exact bytes with gevent/gthread workers.