Limit packaged files#272
Merged
Merged
Conversation
Limit files included in the gem to the ones that are necessary. This skips shipping the gem with directories such as `.github`, `spec` and other files that are not normally accessible and arguably should be skipped. This saves us some bytes in transfer and disk space on all the computers these gems are downloaded to.
tjschuck
approved these changes
Nov 17, 2023
Collaborator
tjschuck
left a comment
There was a problem hiding this comment.
Even though we're talking kilobytes (228 kB -> 164 kB), this is still a -28% change, which seems meaningful enough!
Collaborator
|
Test failure is unrelated: ruby/setup-ruby#496 |
Collaborator
|
New version pushed and tagged.
It looks like the packaged/pushed versions aren't quite the same cuts, but still improvements, considering just how often this gem gets downloaded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit files included in the gem to the ones that are necessary.
This skips shipping the gem with directories such as
.github,specand other files that are not normally accessible and arguably should be skipped.This saves us some bytes in transfer and disk space on all the computers these gems are downloaded to.