-
-
Notifications
You must be signed in to change notification settings - Fork 740
Comparing changes
Open a pull request
base repository: bazel-contrib/rules_go
base: v0.54.1
head repository: bazel-contrib/rules_go
compare: v0.55.0
- 20 commits
- 73 files changed
- 13 contributors
Commits on Apr 19, 2025
-
Checking test suite duration (#4323)
**What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** A test case/suite's duration can be nil in the test JSON. We should check it before dereference it. **Which issues(s) does this PR fix?** Fixes #4318 **Other notes for review**
Configuration menu - View commit details
-
Copy full SHA for a67f6c1 - Browse repository at this point
Copy the full SHA a67f6c1View commit details -
Revert "Fail when expected files are not produced by protoc (#4287)" (#…
…4324) **What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** It's common for a `go_proto_library` to include proto files with and without service definitions at the same time. In this case, the gRPC plugins are needed, but some gRPC plugins don't generate the grpc.pb.go files if there is no service definition. Partially reverting #4287 to restore the previous behavior of creating an empty file **Which issues(s) does this PR fix?** Fixes #4317 **Other notes for review** --------- Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Configuration menu - View commit details
-
Copy full SHA for 66cd5f5 - Browse repository at this point
Copy the full SHA 66cd5f5View commit details
Commits on Apr 22, 2025
-
Add imacros to absolutized cgo env list (#4325)
**What type of PR is this?** > Bug fix **What does this PR do? Why is it needed?** This adds the -imacros flag to the set of cgo compiler flags that are transformed to absolute paths. Currently relative path values for -imacros will fail. **Which issues(s) does this PR fix?** No existing issue, just seems to be a missed flag. **Other notes for review** I have been able to successfully test this locally using my existing cc toolchain.
Configuration menu - View commit details
-
Copy full SHA for 38244a1 - Browse repository at this point
Copy the full SHA 38244a1View commit details -
go_cross: allow transition on compilation_mode (#4320)
<!-- Thanks for sending a PR! Before submitting: 1. If this is your first PR, please read CONTRIBUTING.md and sign the CLA first. We cannot review code without a signed CLA. 2. Please file an issue *first*. All features and most bug fixes should have an associated issue with a design discussed and decided upon. Small bug fixes and documentation improvements don't need issues. 3. New features and bug fixes must have tests. Documentation may need to be updated. If you're unsure what to update, send the PR, and we'll discuss in review. 4. Note that PRs updating dependencies and new Go versions are not accepted. Please file an issue instead. --> **What type of PR is this?** Feature **What does this PR do? Why is it needed?** Let user change the compilation mode with go_cross_binary. This is useful to force a opt mode for a deployment or packaging purposes. **Which issues(s) does this PR fix?** **Other notes for review**
Configuration menu - View commit details
-
Copy full SHA for 185ecb7 - Browse repository at this point
Copy the full SHA 185ecb7View commit details
Commits on Apr 26, 2025
-
Pass config to subanalyzers (#4330)
**What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** Some analyzers require their subanalyzers to be configured. For instance nilaway has dedicated nilaway_config subanalyzer. **Which issues(s) does this PR fix?** Fixes #4329 **Other notes for review** --------- Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Configuration menu - View commit details
-
Copy full SHA for b403a37 - Browse repository at this point
Copy the full SHA b403a37View commit details
Commits on Apr 27, 2025
-
Update BCR presumit matrix (#4331)
**What type of PR is this?** Other **What does this PR do? Why is it needed?** * Adding coverage on Linux arm64 and Bazel 8 * Upgrading Debian version * Dropping coverage on macOS amd64. Those machines are very old now. **Other notes for review**
Configuration menu - View commit details
-
Copy full SHA for 1dd62f4 - Browse repository at this point
Copy the full SHA 1dd62f4View commit details
Commits on Apr 29, 2025
-
Work around incompatibility between zlib and clang 17 (#4332)
Work around bazelbuild/continuous-integration#2269
Configuration menu - View commit details
-
Copy full SHA for f0d3aa7 - Browse repository at this point
Copy the full SHA f0d3aa7View commit details
Commits on May 2, 2025
-
Export new location of support files needed for using Go's WASM outpu…
…t. (#4322) **What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** In order to run code with GOOS=js GOARCH=wasm in the browser, you need to copy a `.js` file from the toolchain. This file location was changed in Go 1.24, which is now also exported in this PR. **Which issues(s) does this PR fix?** n/a **Other notes for review** See also this info from the Go wiki: > For Go 1.23 and earlier, the wasm support files needed in this article are located in misc/wasm, and the path should be replaced when performing operations with files such as lib/wasm/wasm_exec.js. [source](https://go.dev/wiki/WebAssembly)
Configuration menu - View commit details
-
Copy full SHA for 187ba67 - Browse repository at this point
Copy the full SHA 187ba67View commit details
Commits on May 6, 2025
-
Fix incompatibility with
--incompatible_auto_exec_groups(#4141)**What type of PR is this?** Incompatible change **What does this PR do? Why is it needed?** This requires setting the `toolchain` on actions and updating protobuf. **Which issues(s) does this PR fix?** Fix #4139 **Other notes for review**
Configuration menu - View commit details
-
Copy full SHA for b17435b - Browse repository at this point
Copy the full SHA b17435bView commit details
Commits on May 7, 2025
-
Re-spawned test binary should not break PWD (#4336)
**What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** This PR adds a test to reproduce the issue described in #4335, and proposes one possible fix for it: leveraging an environment variable to help the subprocess determine whether it was invoked by Bazel or directly. The test fails without the proposed fix, but it succeeds fine with `go test`. **Which issues(s) does this PR fix?** Fixes #4335 **Other notes for review** The proposed fix is one possible way of doing this. I welcome feedback from maintainers on other approaches here.
Configuration menu - View commit details
-
Copy full SHA for 608bd43 - Browse repository at this point
Copy the full SHA 608bd43View commit details
Commits on May 13, 2025
-
Only emit patch file if nogo has fixes (#4269)
**What type of PR is this?** Feature **What does this PR do? Why is it needed?** This makes it easier to download all relevant patches with `--remote_download_regex` without creating a bunch of empty patch files. **Which issues(s) does this PR fix?** **Other notes for review**
Configuration menu - View commit details
-
Copy full SHA for fb90c46 - Browse repository at this point
Copy the full SHA fb90c46View commit details -
Rename
outtoout_diagnostics(#4341)**What type of PR is this?** Refactor **What does this PR do? Why is it needed?** Follow-up to #4269 **Which issues(s) does this PR fix?** **Other notes for review**
Configuration menu - View commit details
-
Copy full SHA for 5fe82a7 - Browse repository at this point
Copy the full SHA 5fe82a7View commit details
Commits on May 15, 2025
-
**What type of PR is this?** > Cleanup **What does this PR do? Why is it needed?** Replaces rules_proto uses with com_google_protobuf. The former is deprecated.
Configuration menu - View commit details
-
Copy full SHA for cd29704 - Browse repository at this point
Copy the full SHA cd29704View commit details
Commits on May 16, 2025
-
Remove shadow analyzer from TOOLS_NOGO (#4344)
**What type of PR is this?** Other **What does this PR do? Why is it needed?** The shadow analyzer issues many false positives which are not in keeping with Go best practices. Even the upstream documentation for this analyzer admits this and claims that it is experimental. It should not be included in the default list of analyzers provided by nogo (users can still opt-in to it if they want it). **Which issues(s) does this PR fix?** Fixes #4340 **Other notes for review**
Configuration menu - View commit details
-
Copy full SHA for 30a2a1c - Browse repository at this point
Copy the full SHA 30a2a1cView commit details -
Disable
pkgfactanalyzer (#4349)It's just a demo analyzer that serves as an example of the facts mechanism. Context: https://bazelbuild.slack.com/archives/CDBP88Z0D/p1747334404309089?thread_ts=1747334404.309089&cid=CDBP88Z0D
Configuration menu - View commit details
-
Copy full SHA for b79f6d7 - Browse repository at this point
Copy the full SHA b79f6d7View commit details
Commits on May 19, 2025
-
Discourage references to the default SDK (#4351)
The repo contains a host-compatible SDK and thus doesn't behave correctly in multi-platform builds. Fixes #4342
Configuration menu - View commit details
-
Copy full SHA for 99bb9af - Browse repository at this point
Copy the full SHA 99bb9afView commit details -
go/tools/gopackagesdriver: Adding Cgo support (#4338)
go/tools/gopackagesdriver: Filter cgo sources and add cgo processed files The gopackagesdriver today fails to load Go programs with cgo dependencies. ``` go-code/bazel-pkgdrv/external/com_github_mattn_go_sqlite3/backup.go:16:8: could not import C (no metadata for C) ``` These errors come from two sources: - First, the gopackagesdriver includes cgo sources files in the CompiledGoFiles response. - Second, the gopackagesdriver response and CompiledGoFiles do not contain cgo processed Go sources necessary to compile the program. This change addresses both error points by - Exposing the location of cgo generated artifacts in the rules_go archive object. - Filtering out cgo source files from the CompiledGoFiles response, by checking if the files import "C". - Adding cgo processed files to the CompiledGoFiles response by exploiting knowledge of how rules_go compiles cgo files. I am not sure if there is a better solution to leaking build system details to the gopackagesdriver as even 'go list' leaks where the go build cache stores cgo processed files. Though in the case of 'go list' the conventions for cgo processed files are a bit different, they don't seem to have a file extension. For example, ``` $ go list -json=ImportPath,CgoFiles,GoFiles,CompiledGoFiles -compiled -find github.com/mattn/go-sqlite3 "CompiledGoFiles": [ "convert.go", "doc.go", "sqlite3_func_crypt.go", "sqlite3_go18.go", "sqlite3_opt_preupdate.go", "sqlite3_opt_preupdate_omit.go", "/Users/rhang/Library/Caches/go-build/8f/8f8bfe0b75fcceeb093e990af3eaa4f05147147b13db050b2f706cb563280415-d", "/Users/rhang/Library/Caches/go-build/9c/9c0b42e0a548721eb17f0fe5cfc2b6f1c0f0f7fcfb0f0caf526229723b9d4927-d", "/Users/rhang/Library/Caches/go-build/f7/f7e25424abcdc8442dbe22670456cab79a881268995c4ed43715e6d56930bff6-d", ... ``` This PR resolves #4337 additional details are provided in the issue.1Configuration menu - View commit details
-
Copy full SHA for 11c6145 - Browse repository at this point
Copy the full SHA 11c6145View commit details
Commits on May 22, 2025
-
Pass headers along as transitive dependencies (#4298)
This fixes github.com/cloudflare/circl relative imports by making those headers available at compile time. **What type of PR is this?** Feature **What does this PR do? Why is it needed?** Expose headers in GoArchive so that compilepkg can make them visible. This will make it possible for relative imports to find header files. **Which issues(s) does this PR fix?** Fixes #4154 **Other notes for review**
Configuration menu - View commit details
-
Copy full SHA for 393faea - Browse repository at this point
Copy the full SHA 393faeaView commit details
Commits on May 28, 2025
-
Allowing a go_proto_compiler to indicate whether it always generate f…
…iles (#4364) **What type of PR is this?** Feature **What does this PR do? Why is it needed?** This PR allows a `go_proto_compiler` to indicate whether it always generate files, if so, we can apply more strict check to the output of the proto compiler. **Which issues(s) does this PR fix?** This is an alternative way to fix #3949 **Other notes for review**
Configuration menu - View commit details
-
Copy full SHA for fc0cf79 - Browse repository at this point
Copy the full SHA fc0cf79View commit details
Commits on Jun 1, 2025
-
fix: merge '-Wl,' with next value when (#4367)
**What type of PR is this?** > Bug fix **What does this PR do? Why is it needed?** Previously if we pass `-extldflags,-Wl,--thread` into command line, it will only recognizes `-Wl` and ignores `--thread`. **Which issues(s) does this PR fix?** #3921 Fixes # If we see `-Wl`, we can merge with next value in the list. **Other notes for review** Co-authored-by: zhanning.lu <zhanning.lu@bytedance.com>
Configuration menu - View commit details
-
Copy full SHA for 8e7d9cd - Browse repository at this point
Copy the full SHA 8e7d9cdView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.54.1...v0.55.0