Introduce repeatable_string_flag.#593
Merged
tetromino merged 13 commits intobazelbuild:mainfrom Sep 23, 2025
Merged
Conversation
New settings of this flag type do not override each other; they are concatenated into a list. --foo=bar --foo=baz -> [bar, baz]. This is the equivalent of a string typed native flag with allow_multiple.
tetromino
approved these changes
Sep 18, 2025
Collaborator
tetromino
left a comment
There was a problem hiding this comment.
Overall lgtm
Nit: is it worth adding a test for this? (See tests/common_settings/BUILD)
fmeum
reviewed
Sep 19, 2025
Contributor
Author
For posterity, I did not add a test because this flag type doesn't become a variable, so it's not a possible to make the comparable test. I tried using a custom starlark rule that had the an attr of this flag type, but it's overkill. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New settings of this flag type do not override each other; they are concatenated into a list. --foo=bar --foo=baz -> [bar, baz]. This is the equivalent of a string typed native flag with allow_multiple.