Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 222b0853a8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| finalize: | ||
| needs: publish | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - run: gh release edit "$TAG" --draft=false --repo "$GITHUB_REPOSITORY" |
There was a problem hiding this comment.
Add write permissions for release finalization
The new finalize job calls gh release edit ... --draft=false to publish the release, but this job does not request GITHUB_TOKEN write scopes. GitHub’s reusable-workflow docs state that when the calling job does not set jobs.<job_id>.permissions, the called workflow gets default token permissions; with restricted defaults this leaves gh release edit unable to update the release and the workflow ends with the release still in draft state. Please add explicit permissions (at least contents: write) for this job (or for the calling job) so finalization is reliable.
Useful? React with 👍 / 👎.
No description provided.