Export new location of support files needed for using Go's WASM output.#4322
Merged
fmeum merged 1 commit intobazel-contrib:masterfrom May 2, 2025
Merged
Export new location of support files needed for using Go's WASM output.#4322fmeum merged 1 commit intobazel-contrib:masterfrom
fmeum merged 1 commit intobazel-contrib:masterfrom
Conversation
fmeum
approved these changes
Apr 19, 2025
fmeum
reviewed
Apr 19, 2025
Contributor
Author
|
I see, I'll need to update the glob to match the old and the new path in one pattern. |
Member
|
That's even better |
5858ab0 to
1e8727c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
In order to run code with GOOS=js GOARCH=wasm in the browser, you need to copy a
.jsfile from the toolchain.This file location was changed in Go 1.24, which is now also exported in this PR.
Which issues(s) does this PR fix?
n/a
Other notes for review
See also this info from the Go wiki:
source