bzlmod: allow non-default go.work file names#2303
Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom Mar 12, 2026
Merged
bzlmod: allow non-default go.work file names#2303jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod merged 1 commit intobazel-contrib:masterfrom
Conversation
The go command accepts any file as a workspace file via the GOWORK environment variable, and writes checksums to a sibling file with a .sum suffix (e.g. GOWORK=go.bazel.work produces go.bazel.work.sum). go_deps.from_file(go_work = ...) currently rejects any name other than go.work, and hardcodes go.work.sum as the sum file name. This is stricter than the go command itself. Notably, go_work_from_label already accepts any name; only the sum-file path checks. Remove the name check and derive the sum file name from the work file name. A non-default name is useful when a repository wants a Bazel-only workspace that the go toolchain won't auto-discover (the toolchain walks up directories looking specifically for go.work), so native go builds remain unaffected by the Bazel workspace configuration.
Contributor
Author
jayconrod
approved these changes
Mar 12, 2026
Contributor
jayconrod
left a comment
There was a problem hiding this comment.
Thanks for fixing! I'd completely forgotten that GOWORK could be used to set the work file name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The go command accepts any file as a workspace file via the GOWORK environment variable, and writes checksums to a sibling file with a .sum suffix (e.g. GOWORK=go.bazel.work produces go.bazel.work.sum).
go_deps.from_file(go_work = ...) currently rejects any name other than go.work, and hardcodes go.work.sum as the sum file name. This is stricter than the go command itself. Notably, go_work_from_label already accepts any name; only the sum-file path checks.
Remove the name check and derive the sum file name from the work file name.
A non-default name is useful when a repository wants a Bazel-only workspace that the go toolchain won't auto-discover (the toolchain walks up directories looking specifically for go.work), so native go builds remain unaffected by the Bazel workspace configuration.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
go_repository
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #2302
Other notes for review