tests: convert most remaining integration tests#2294
Merged
Conversation
gazelle_binary accepts a "version" attribute, used to select between either the ./cmd/gazelle or ./v2/cmd/gazelle main package. The default is determined by Gazelle's module version. //tests now has separate gazelle_binary targets and test targets for each version so that we don't regress either v1 or v2. For #2272
So that the tests can cover both v1 and v2.
Contributor
Author
|
Sorry this is huge. Should be the last one of these conversions. |
fmeum
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What package or component does this PR mostly affect?
What does this PR do? Why is it needed?
Convert tests that weren't converted earlier by #2293 and remove the corresponding old integration tests.
The remaining integration tests can't be converted because they aren't compatible with the directory test framework. Most of them cover
update-repos, which isn't supported there and won't be supported in v2 anyway. A few tests have excessively long names or subtests, and runfiles couldn't be accessed on Windows.Which issues(s) does this PR fix?
For #2272
Other notes for review