Skip to content

gazelle_binary: support either v1 or v2#2281

Merged
jayconrod merged 6 commits intomasterfrom
v2-4-gazelle-binary
Feb 23, 2026
Merged

gazelle_binary: support either v1 or v2#2281
jayconrod merged 6 commits intomasterfrom
v2-4-gazelle-binary

Conversation

@jayconrod
Copy link
Copy Markdown
Contributor

What type of PR is this?

Other

What package or component does this PR mostly affect?

gazelle_binary

What does this PR do? Why is it needed?

gazelle_binary accepts a "version" attribute, used to select between either the ./cmd/gazelle or ./v2/cmd/gazelle main package. The default is determined by Gazelle's module version.

//tests now has separate gazelle_binary targets and test targets for each version so that we don't regress either v1 or v2.

Which issues(s) does this PR fix?

For #2272

Other notes for review

gazelle_binary accepts a "version" attribute, used to select between
either the ./cmd/gazelle or ./v2/cmd/gazelle main package. The default
is determined by Gazelle's module version.

//tests now has separate gazelle_binary targets and test targets for
each version so that we don't regress either v1 or v2.

For #2272
@jayconrod jayconrod requested a review from fmeum February 22, 2026 17:38
Comment thread internal/gazelle_binary.bzl
@jayconrod jayconrod merged commit 76b0b0c into master Feb 23, 2026
17 checks passed
@jayconrod jayconrod deleted the v2-4-gazelle-binary branch February 23, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants