Disable proto library generation for protocompile#2278
Merged
fmeum merged 1 commit intobazel-contrib:masterfrom Jan 26, 2026
Merged
Disable proto library generation for protocompile#2278fmeum merged 1 commit intobazel-contrib:masterfrom
fmeum merged 1 commit intobazel-contrib:masterfrom
Conversation
`github.com/bufbuild/protocompile` bundles well-known .proto files under `wellknownimports/google/`, which is conflicting with the `go_proto_library` targets that Gazelle wanted to generate.
fmeum
approved these changes
Jan 26, 2026
fmeum
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
cmd/gazelle
What does this PR do? Why is it needed?
github.com/bufbuild/protocompilebundles well-known .proto files underwellknownimports/google/, which is conflicting with thego_proto_librarytargets that Gazelle wanted to generate.Which issues(s) does this PR fix?
Addresses #2029 although that issue technically was asking for something else.
Other notes for review