v2: extract fix-update logic to v2/cmd/gazelle/update#2276
Merged
v2: extract fix-update logic to v2/cmd/gazelle/update#2276
Conversation
Still a pretty old version, but a year newer than what we had before. This gives us fancy range loops. Removed some apparently unused compatibility definitions referencing multiple versions of Go. For #2272
go.work is unrelated to the Bazel build. It keeps my editor happy without gopackagesdriver. Bazel needs to rebuild all of gazelle after every change via go_repository_tools, so gopackagesdriver isn't really usable. For #2272
This new package now implements Gazelle's core fix/update functionality. cmd/gazelle and v2/cmd/gazelle will both we wrappers around this, though the update-repos command will remain in v1, since we're dropping it in v2. Also modifed go_repository_tools to work in module mode, since it would actually require deeper changes to continue working in GOPATH mode. For #2272
fmeum
approved these changes
Jan 26, 2026
Member
fmeum
left a comment
There was a problem hiding this comment.
So glad to see this GOPATH dependency go away!
fmeum
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What package or component does this PR mostly affect?
What does this PR do? Why is it needed?
This new package now implements Gazelle's core fix/update functionality. cmd/gazelle and v2/cmd/gazelle will both we wrappers around this, though the update-repos command will remain in v1, since we're dropping it in v2.
Also modifed go_repository_tools to work in module mode, since it would actually require deeper changes to continue working in GOPATH mode.
Which issues(s) does this PR fix?
For #2272
Other notes for review
Also copied
internal/wspace. It's an internal package, so it can't be moved and forwarded unfortunately.