Skip to content

Upgrade Go to 1.24.12, rules_go to 0.59.0, and sync deps to WORKSPACE#2274

Merged
jayconrod merged 5 commits intomasterfrom
upgrade-go
Jan 27, 2026
Merged

Upgrade Go to 1.24.12, rules_go to 0.59.0, and sync deps to WORKSPACE#2274
jayconrod merged 5 commits intomasterfrom
upgrade-go

Conversation

@jayconrod
Copy link
Copy Markdown
Contributor

@jayconrod jayconrod commented Jan 25, 2026

What type of PR is this?

Other

What package or component does this PR mostly affect?

all

What does this PR do? Why is it needed?

  • Go is still a pretty old version, but a year newer than what we had before. This gives us fancy range loops.
  • rules_go is now the latest version, needed to resolve some nogo issues in WORKSPACE mode, though I'm not sure if it was actually a rules_go problem or upgrading the ancient version of x/tools we were on.
  • Synced dependencies from go.mod / MODULE.bazel to WORKSPACE. These had completely diverged.
  • Removed some apparently unused compatibility definitions referencing multiple versions of Go.
  • Disabled Stardoc targets in WORKSPACE mode. They no longer build due to some hidden dependency on rules_cc. Don't care.

Which issues(s) does this PR fix?

For #2272

Other notes for review

Still a pretty old version, but a year newer than what we had before.
This gives us fancy range loops.

Removed some apparently unused compatibility definitions referencing
multiple versions of Go.

For #2272
@jayconrod jayconrod changed the title Go: upgrade to 1.24.12 Upgrade Go to 1.24.12, rules_go to 0.59.0, and sync deps to WORKSPACE Jan 25, 2026
@jayconrod jayconrod requested a review from fmeum January 25, 2026 21:04
@jayconrod jayconrod mentioned this pull request Jan 25, 2026
Comment thread cmd/fetch_repo/BUILD.bazel
@jayconrod jayconrod enabled auto-merge (squash) January 27, 2026 19:47
@jayconrod jayconrod merged commit 2f939c7 into master Jan 27, 2026
17 checks passed
@jayconrod jayconrod deleted the upgrade-go branch January 27, 2026 21:08
rdesgroppes added a commit to DataDog/datadog-agent that referenced this pull request Feb 16, 2026
Update Gazelle from v0.47.0 to master (commit 6b2aecc, Feb 13 2026)
to benefit from critical fixes and improvements:

Critical fixes:
- Fix goexperiment build tags support for Go 1.24+ (bazel-contrib/bazel-gazelle#2254, bazel-contrib/bazel-gazelle#2257)
- Fix race condition in walk (bazel-contrib/bazel-gazelle#2238)
- Fix module resolution with overrides (bazel-contrib/bazel-gazelle#2270)
- Fix exports_files and package conflicts (bazel-contrib/bazel-gazelle#2248)

Dependencies:
- Upgrade to Go 1.24.12 and rules_go 0.59.0 (bazel-contrib/bazel-gazelle#2274)

This follows the same pattern already used for rules_go and rules_pkg
overrides in MODULE.bazel.
gh-worker-dd-mergequeue-cf854d Bot pushed a commit to DataDog/datadog-agent that referenced this pull request Feb 16, 2026
### What does this PR do?
Update Gazelle from v0.47.0 to unreleased `master`.

### Motivation
To benefit from fixes relevant to our Go 1.25.7 build:
- bazel-contrib/bazel-gazelle#2238
- bazel-contrib/bazel-gazelle#2248
- bazel-contrib/bazel-gazelle#2254
- bazel-contrib/bazel-gazelle#2257
- bazel-contrib/bazel-gazelle#2270

Also, their internal dependency on `rules_go` now matches ours:
- bazel-contrib/bazel-gazelle#2274

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
rdesgroppes added a commit to DataDog/datadog-agent that referenced this pull request Mar 26, 2026
### What does this PR do?
Bump `gazelle` from 0.47.0 to 0.48.0 and drop the `git_override` that
pinned to an unreleased commit on their `master`.

### Motivation
v0.48.0 ships both fixes the override was waiting for:
- bazel-contrib/bazel-gazelle#2274
- bazel-contrib/bazel-gazelle#2284

### Describe how you validated your changes
`bazel run //:gazelle` produces no change.
gh-worker-dd-mergequeue-cf854d Bot pushed a commit to DataDog/datadog-agent that referenced this pull request Mar 26, 2026
### What does this PR do?
Bump `gazelle` from 0.47.0 to 0.48.0 and drop the `git_override` that pinned to an unreleased commit on their `master`.

### Motivation
v0.48.0 ships both fixes the override was waiting for:
- bazel-contrib/bazel-gazelle#2274
- bazel-contrib/bazel-gazelle#2284

### Describe how you validated your changes
`bazel run //:gazelle` produces no change.

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants