Add check to see if testdata is empty when determining when to add data#2262
Merged
jayconrod merged 6 commits intobazel-contrib:masterfrom Jan 7, 2026
Merged
Conversation
fmeum
approved these changes
Jan 2, 2026
jayconrod
reviewed
Jan 5, 2026
Contributor
jayconrod
left a comment
There was a problem hiding this comment.
Fix seems reasonable. Please add a test in //tests.
jayconrod
approved these changes
Jan 7, 2026
Contributor
jayconrod
left a comment
There was a problem hiding this comment.
Thanks, this looks good.
I appreciate your patience with Walk and with the tests. Reducing I/O should speed things up. I'm working on Gazelle v2, and fixing walk.GetDirInfo will be part of that (among many other things).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
language/go
What does this PR do? Why is it needed?
Adds logic to check that a testdata subdirectory is not empty before adding it as a data source.
Which issues(s) does this PR fix?
Fixes #2233