Merged
Conversation
jayconrod
approved these changes
Dec 2, 2025
pcj
pushed a commit
to stackb/bazel-gazelle
that referenced
this pull request
Dec 23, 2025
**What type of PR is this?** Feature **What package or component does this PR mostly affect?** all **What does this PR do? Why is it needed?** This makes it easier to emit standardized globs from gazelle languages without complex logic to verify the exact set of patterns needed. (Especially since merging globs doesn't seem to work correctly in all cases) While here, I tweaked how we emit True/False literals to align with how they're parsed by `buildtools`, otherwise we had to handle multiple ways to parse `allow_empty = True` (both Literal and Ident). I can revert this bit if we think it's unsafe or was done like this intentionally, but it felt like matching what the parser itself would emit is better **Which issues(s) does this PR fix?** Fixes # **Other notes for review** Co-authored-by: Jay Conrod <jay@engflow.com>
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What package or component does this PR mostly affect?
all
What does this PR do? Why is it needed?
This makes it easier to emit standardized globs from gazelle languages without complex logic to verify the exact set of patterns needed. (Especially since merging globs doesn't seem to work correctly in all cases)
While here, I tweaked how we emit True/False literals to align with how they're parsed by
buildtools, otherwise we had to handle multiple ways to parseallow_empty = True(both Literal and Ident). I can revert this bit if we think it's unsafe or was done like this intentionally, but it felt like matching what the parser itself would emit is betterWhich issues(s) does this PR fix?
Fixes #
Other notes for review