Add default Gazelle override for tflint-plugin-sdk#2230
Merged
jayconrod merged 2 commits intobazel-contrib:masterfrom Nov 19, 2025
Merged
Add default Gazelle override for tflint-plugin-sdk#2230jayconrod merged 2 commits intobazel-contrib:masterfrom
jayconrod merged 2 commits intobazel-contrib:masterfrom
Conversation
Adds `gazelle:proto disable` directive for `github.com/terraform-linters/tflint-plugin-sdk` to the default overrides.
The tflint-plugin-sdk repository includes pre-generated protobuf bindings.
When Gazelle attempts to regenerate these bindings, it produces incompatible code that causes build failures with undefined type errors.
I have verified that disabling proto generation allows successful builds of projects depending on tflint-plugin-sdk by using a MODULE.bazel extract like:
```
go_deps.gazelle_override(
directives = [
"gazelle:proto disable",
],
path = "github.com/terraform-linters/tflint-plugin-sdk",
)
```
fmeum
approved these changes
Nov 16, 2025
Member
|
Thanks for sending the PR. We will have to fix unrelated issues with the latest Bazel version before we can merge it. |
pcj
pushed a commit
to stackb/bazel-gazelle
that referenced
this pull request
Dec 23, 2025
**What type of PR is this?**
Bug fix
**What package or component does this PR mostly affect?**
bzlmod
**What does this PR do? Why is it needed?**
Adds `gazelle:proto disable` directive for
`github.com/terraform-linters/tflint-plugin-sdk` to the default
overrides.
The tflint-plugin-sdk repository includes pre-generated protobuf
bindings.
When Gazelle attempts to regenerate these bindings, it produces
incompatible
code that causes build failures with undefined type errors.
I have verified that disabling proto generation allows successful builds
of
projects depending on tflint-plugin-sdk by using a MODULE.bazel override
like:
```python
go_deps.gazelle_override(
directives = [
"gazelle:proto disable",
],
path = "github.com/terraform-linters/tflint-plugin-sdk",
)
```
**Which issues(s) does this PR fix?**
N/A
**Other notes for review**
Small fix similar to bazel-contrib#2062 for hashicorp/go-plugin)
Co-authored-by: Jay Conrod <jay@engflow.com>
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
bzlmod
What does this PR do? Why is it needed?
Adds
gazelle:proto disabledirective forgithub.com/terraform-linters/tflint-plugin-sdkto the default overrides.The tflint-plugin-sdk repository includes pre-generated protobuf bindings.
When Gazelle attempts to regenerate these bindings, it produces incompatible
code that causes build failures with undefined type errors.
I have verified that disabling proto generation allows successful builds of
projects depending on tflint-plugin-sdk by using a MODULE.bazel override
like:
Which issues(s) does this PR fix?
N/A
Other notes for review
Small fix similar to #2062 for hashicorp/go-plugin)