Skip to content

Add default Gazelle override for tflint-plugin-sdk#2230

Merged
jayconrod merged 2 commits intobazel-contrib:masterfrom
rorychatterton:patch-1
Nov 19, 2025
Merged

Add default Gazelle override for tflint-plugin-sdk#2230
jayconrod merged 2 commits intobazel-contrib:masterfrom
rorychatterton:patch-1

Conversation

@rorychatterton
Copy link
Copy Markdown
Contributor

What type of PR is this?

Bug fix

What package or component does this PR mostly affect?

bzlmod

What does this PR do? Why is it needed?

Adds gazelle:proto disable directive for
github.com/terraform-linters/tflint-plugin-sdk to the default overrides.

The tflint-plugin-sdk repository includes pre-generated protobuf bindings.
When Gazelle attempts to regenerate these bindings, it produces incompatible
code that causes build failures with undefined type errors.

I have verified that disabling proto generation allows successful builds of
projects depending on tflint-plugin-sdk by using a MODULE.bazel override
like:

go_deps.gazelle_override(
    directives = [
        "gazelle:proto disable",
    ],
    path = "github.com/terraform-linters/tflint-plugin-sdk",
)

Which issues(s) does this PR fix?

N/A

Other notes for review

Small fix similar to #2062 for hashicorp/go-plugin)

Adds `gazelle:proto disable` directive for `github.com/terraform-linters/tflint-plugin-sdk` to the default overrides.

The tflint-plugin-sdk repository includes pre-generated protobuf bindings.

When Gazelle attempts to regenerate these bindings, it produces incompatible code that causes build failures with undefined type errors.

I have verified that disabling proto generation allows successful builds of projects depending on tflint-plugin-sdk by using a MODULE.bazel extract like:

```
go_deps.gazelle_override(
    directives = [
        "gazelle:proto disable",
    ],
    path = "github.com/terraform-linters/tflint-plugin-sdk",
)
```
@fmeum
Copy link
Copy Markdown
Member

fmeum commented Nov 16, 2025

Thanks for sending the PR. We will have to fix unrelated issues with the latest Bazel version before we can merge it.

@jayconrod jayconrod enabled auto-merge (squash) November 19, 2025 16:28
@jayconrod jayconrod merged commit 2f37cce into bazel-contrib:master Nov 19, 2025
14 checks passed
@rorychatterton rorychatterton deleted the patch-1 branch November 21, 2025 01:48
pcj pushed a commit to stackb/bazel-gazelle that referenced this pull request Dec 23, 2025
**What type of PR is this?**

Bug fix

**What package or component does this PR mostly affect?**

bzlmod

**What does this PR do? Why is it needed?**

Adds `gazelle:proto disable` directive for
`github.com/terraform-linters/tflint-plugin-sdk` to the default
overrides.

The tflint-plugin-sdk repository includes pre-generated protobuf
bindings.
When Gazelle attempts to regenerate these bindings, it produces
incompatible
code that causes build failures with undefined type errors.

I have verified that disabling proto generation allows successful builds
of
projects depending on tflint-plugin-sdk by using a MODULE.bazel override
like:

```python
go_deps.gazelle_override(
    directives = [
        "gazelle:proto disable",
    ],
    path = "github.com/terraform-linters/tflint-plugin-sdk",
)
```

**Which issues(s) does this PR fix?**

N/A 

**Other notes for review**

Small fix similar to bazel-contrib#2062 for hashicorp/go-plugin)

Co-authored-by: Jay Conrod <jay@engflow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants