Skip to content

Accept go.sum files with git conflict markers#2225

Merged
fmeum merged 3 commits intomasterfrom
4505-go-mod-conflict
Nov 20, 2025
Merged

Accept go.sum files with git conflict markers#2225
fmeum merged 3 commits intomasterfrom
4505-go-mod-conflict

Conversation

@fmeum
Copy link
Copy Markdown
Member

@fmeum fmeum commented Nov 8, 2025

What type of PR is this?

Feature

What package or component does this PR mostly affect?

go_deps

What does this PR do? Why is it needed?

Which issues(s) does this PR fix?

Fixes bazel-contrib/rules_go#4505

Other notes for review

Comment thread tests/bzlmod/go_mod_test.bzl Outdated
Comment thread internal/bzlmod/go_mod.bzl
@fmeum fmeum enabled auto-merge (squash) November 12, 2025 05:44
@fmeum fmeum force-pushed the 4505-go-mod-conflict branch from 7e83faa to 692bdd1 Compare November 19, 2025 07:33
Also tell users how to avoid these conflicts in the first place.
@fmeum fmeum force-pushed the 4505-go-mod-conflict branch from 692bdd1 to e512bb9 Compare November 20, 2025 07:48
@fmeum fmeum merged commit 9d26c70 into master Nov 20, 2025
16 checks passed
@fmeum fmeum deleted the 4505-go-mod-conflict branch November 20, 2025 07:53
pcj pushed a commit to stackb/bazel-gazelle that referenced this pull request Dec 23, 2025
**What type of PR is this?**

Feature

**What package or component does this PR mostly affect?**

`go_deps`

**What does this PR do? Why is it needed?**

**Which issues(s) does this PR fix?**

Fixes bazel-contrib/rules_go#4505

**Other notes for review**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

go.sum merge conflicts require cleaning before building well.

3 participants