go_repository_tools: build with -buildvcs=false#2324
Merged
Conversation
fmeum
approved these changes
Apr 5, 2026
wonderyl
pushed a commit
to wonderyl/bazel-gazelle
that referenced
this pull request
Apr 13, 2026
**What type of PR is this?** > Bug fix **What package or component does this PR mostly affect?** `go_repository_tools` **What does this PR do? Why is it needed?** Adds `-buildvcs=false` to the command line when building `gazelle` and other binaries for use within `go_repository`. Leaving VCS stamping enabled may cause problems if a VCS tool is misconfigured. We don't really need VCS stamping. **Which issues(s) does this PR fix?** Fixes bazel-contrib#2323 **Other notes for review**
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What package or component does this PR mostly affect?
go_repository_toolsWhat does this PR do? Why is it needed?
Adds
-buildvcs=falseto the command line when buildinggazelleand other binaries for use withingo_repository.Leaving VCS stamping enabled may cause problems if a VCS tool is misconfigured. We don't really need VCS stamping.
Which issues(s) does this PR fix?
Fixes #2323
Other notes for review