Ensure syntactic ordering when visiting array-type AST nodes#17357
Merged
JLHwung merged 4 commits intobabel:mainfrom Jun 5, 2025
Merged
Ensure syntactic ordering when visiting array-type AST nodes#17357JLHwung merged 4 commits intobabel:mainfrom
JLHwung merged 4 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59518 |
nicolo-ribaudo
approved these changes
Jun 2, 2025
liuxingbaoyu
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #16710 we ensured the visitor keys ordering for most AST nodes. However, the previous tests overlooked the array type AST nodes, the start position check never kicked in because we are comparing two
undefined. The issue now surfaces thanks to #17339.In this PR we expand the check such that it works for both array and object types. Then we fixed the reported incorrect ordering. We also added a new object pattern test for the legacy decorator since they were previously not covered by any parser tests.