fix(parser): Terminate modifier parsing at newline#17307
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom May 13, 2025
magic-akari:fix/issue-17305
Merged
fix(parser): Terminate modifier parsing at newline#17307nicolo-ribaudo merged 3 commits intobabel:mainfrom magic-akari:fix/issue-17305
nicolo-ribaudo merged 3 commits intobabel:mainfrom
magic-akari:fix/issue-17305
Conversation
Contributor
magic-akari
commented
May 13, 2025
| Q | A |
|---|---|
| Fixed Issues? | Fixes: #17305 |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59322 |
JLHwung
approved these changes
May 13, 2025
| }); | ||
| } | ||
|
|
||
| if (this.hasPrecedingLineBreak()) { |
Contributor
There was a problem hiding this comment.
We already check the newline in tsNextTokenCanFollowModifier, but somehow we missed this check for the static token, could you move the newline check there? So we don't have to check the line break for every other modifiers here.
JLHwung
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.