Fix: always initialize ExportDeclaration attributes#17164
Merged
JLHwung merged 8 commits intobabel:mainfrom Mar 6, 2025
Merged
Fix: always initialize ExportDeclaration attributes#17164JLHwung merged 8 commits intobabel:mainfrom
JLHwung merged 8 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58815 |
nicolo-ribaudo
approved these changes
Mar 6, 2025
laine-hallot
pushed a commit
to laine-hallot/uwu-parser
that referenced
this pull request
Mar 31, 2025
* chore: bump eslint and espree * fix: always initialize ExportDeclaration attributes * update AST fixtures * fix: initialize attributes when importAssertions is not enabled * update AST fixtures * update test snapshot * update Makefile.js * update Babel 8 AST fixtures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI is failing because recently espree supported the ES2025 import attributes. espree always initialize
attributesfor the export declaration while Babel only do so when we see thefrom ...source.I think this is a bug for us since we already handle it in the espree's way for the legacy import assertions, but somehow it is overlooked in import attributes. Here we will initialize
attributesproperty unlessimportAssertionsplugin is enabled.