Updating lib/core/README.md about Dispatching requests#3772
Merged
jasonsaayman merged 2 commits intoaxios:masterfrom Apr 30, 2021
Merged
Updating lib/core/README.md about Dispatching requests#3772jasonsaayman merged 2 commits intoaxios:masterfrom
lib/core/README.md about Dispatching requests#3772jasonsaayman merged 2 commits intoaxios:masterfrom
Conversation
Member
jasonsaayman
left a comment
There was a problem hiding this comment.
Please check out the comment I left.
| The modules found in `core/` should be modules that are specific to the domain logic of axios. These modules would most likely not make sense to be consumed outside of the axios module, as their logic is too specific. Some examples of core modules are: | ||
|
|
||
| - Dispatching requests | ||
| - requests send at `adapters/` (see lib/adapters/README.md). |
Member
There was a problem hiding this comment.
Can you change this to read:
Requests sent via
adapters/(see lib/adapters/README.md)
mbargiel
pushed a commit
to mbargiel/axios
that referenced
this pull request
Jan 27, 2022
* Updating lib/core/README.md :Dispatching requests * Fixing expression
This was referenced Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi :)
I read code, and supplemented the document.