chore(codegen): differentiate type imports#7897
Merged
Conversation
kuhe
commented
Mar 27, 2026
| UserAgent as __UserAgent, | ||
| } from "@smithy/types"; | ||
| import { Readable } from "stream"; | ||
| import type { Readable as Readable } from "node:stream"; |
Contributor
Author
There was a problem hiding this comment.
this is a workaround only affecting checksum clients
writer.addImport("type Readable", "Readable", "node:stream")The addTypeImport API does not support arbitrary strings, since the string-based module import is deprecated (too easy to write an import of a module that isn't declared in the dependency list).
However, node packages don't need to be added to dependencies.
kuhe
commented
Mar 27, 2026
| ); | ||
| Map<String, HttpAuthSchemeParameter> httpAuthSchemeParameters = | ||
| AuthUtils.collectHttpAuthSchemeParameters(effectiveHttpAuthSchemes.values()); | ||
| w.addDependency(TypeScriptDependency.SMITHY_TYPES); |
Contributor
Author
There was a problem hiding this comment.
most addDependency calls can be removed because add[Type]Import when given a dependency object will automatically register it.
00362fc to
fad23f9
Compare
trivikr
approved these changes
Mar 27, 2026
fad23f9 to
1bfb2c5
Compare
1bfb2c5 to
dcacac8
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
codegen application for smithy-lang/smithy-typescript@3a71b57
Description
changes unnecessary runtime imports to type imports
Testing
CI, and this is covered by index tests (
make test-indices).Checklist
*.integ.spec.ts) or E2E tests.@public,@internaltags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.