Merged
Conversation
lucix-aws
approved these changes
Oct 5, 2023
isaiahvita
approved these changes
Oct 6, 2023
Contributor
Author
|
Hi @lucix-aws , I assume you will merge the PR? I do not have permissions and the errors do not seem related to the PR. |
1adf746 to
b24cee1
Compare
Contributor
|
@a-canya -- Yes sorry for the delay. I've just added a changelog entry and some tests cases to cover the new behavior. Will merge today once this round of CI (non-deprecated go runtimes, read on) passes.
Correct, this doesn't block the merge at all. Deprecated-runtime CI has been flaky for some time now. I've been leaving it alone given the impending runtime support policy update (at which point it will go away). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #2295