Skip to content

fix(core): "exports cannot be updated" for cross-region references#37790

Merged
mergify[bot] merged 3 commits into
mainfrom
otaviom/revert-gso
May 7, 2026
Merged

fix(core): "exports cannot be updated" for cross-region references#37790
mergify[bot] merged 3 commits into
mainfrom
otaviom/revert-gso

Conversation

@otaviomacedo
Copy link
Copy Markdown
Contributor

@otaviomacedo otaviomacedo commented May 7, 2026 •
edited
Loading

The ExportWriter/ExportReader mechanism produces strong references (emulating CloudFormation's mechanism for Fn::ImportValue/Export). As such, we can't simply replace it with Fn::GetStackOutput, and we'll need a feature flag to control the behavior.

Closes #37788.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@otaviomacedo otaviomacedo requested a review from a team as a code owner May 7, 2026 13:30
@github-actions github-actions Bot added the p2 label May 7, 2026
@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label May 7, 2026
@mergify mergify Bot temporarily deployed to automation May 7, 2026 13:31 Inactive
@mergify mergify Bot temporarily deployed to automation May 7, 2026 13:31 Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026 •
edited
Loading

⚠️ This pull request description does not follow the correct template structure.

PRs without a linked issue will receive lower priority for review and merging. Please update the description to follow the PR template and include a line like Closes #123 in the Issue section. If no existing issue matches your change, create one first.

@otaviomacedo otaviomacedo requested a review from rix0rrr May 7, 2026 13:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026 •
edited
Loading

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.
To suppress a specific rule, see Suppressing Rules.

TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results384 ran383 passed1 failed
TestResult
Security Guardian Results
packages/@aws-cdk-testing/framework-integ/test/aws-cloudformation/test/integ.core-cross-region-references.js.snapshot/cross-region-producer.template.json
sqs-encryption-enabled.guard❌ failure

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026 •
edited
Loading

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.
To suppress a specific rule, see Suppressing Rules.

TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results with resolved templates384 ran382 passed2 failed
TestResult
Security Guardian Results with resolved templates
packages/@aws-cdk-testing/framework-integ/test/aws-cloudformation/test/integ.core-cross-region-references.js.snapshot/cross-region-producer.template.json
sqs-encryption-enabled.guard❌ failure
packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-with-replication.js.snapshot/integ-pipeline-consumer-stack.template.json
iam-role-root-principal-needs-conditions.guard❌ failure

@otaviomacedo otaviomacedo self-assigned this May 7, 2026
@otaviomacedo otaviomacedo added p0 and removed p2 labels May 7, 2026
@github-actions github-actions Bot added the bug This issue is a bug. label May 7, 2026
@rix0rrr rix0rrr changed the title chore: revert "feat(core): add Fn::GetStackOutput for cross-region references fix(core): "exports cannot be updated" for cross-region references May 7, 2026
@otaviomacedo otaviomacedo requested a review from a team May 7, 2026 13:40
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 7, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 7, 2026 •
edited
Loading

Merge Queue Status

  • ✅ Entered queue — 2026-05-07 15:02 UTC · Rule: default-squash
  • ✅ Checks passed · in-place
  • ✅ Merged — 2026-05-07 20:53 UTC · at d1778cb587285a77ef4d1d39f72fb9d270c9d550 · squash

This pull request spent 5 hours 51 minutes in the queue, including 31 minutes 41 seconds running CI.

Required conditions to merge

@mergify mergify Bot temporarily deployed to automation May 7, 2026 20:21 Inactive
@mergify mergify Bot temporarily deployed to automation May 7, 2026 20:21 Inactive
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 7, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify Bot merged commit af11f00 into main May 7, 2026
21 of 25 checks passed
@mergify mergify Bot deleted the otaviom/revert-gso branch May 7, 2026 20:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@otaviomacedo otaviomacedo

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. p0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(core): aws-cdk-lib 2.253.0 breaks existing stacks with crossRegionReferences=true

3 participants

@otaviomacedo @rix0rrr @aws-cdk-automation