Work around os.cpus() returning an empty array on unsupported platforms#3095
Merged
novemberborn merged 5 commits intoavajs:mainfrom Aug 27, 2022
Merged
Work around os.cpus() returning an empty array on unsupported platforms#3095novemberborn merged 5 commits intoavajs:mainfrom
novemberborn merged 5 commits intoavajs:mainfrom
Conversation
Contributor
Author
|
Here's the Node.js issue describing the |
Member
|
On what platform are you running into this, and with which version of Node.js? |
Contributor
Author
|
I'm using Node.js 18.7.0 and running it on Android |
Member
|
Okay now I am curious, why run AVA on Android? |
Contributor
Author
|
Well, as I wanted to try web development on the go and I don't have a laptop, I decided to do it on my Android tablet, using Termux and Neovim. Most utilities just work and only some refuse to work because of bugs and poor (if any) support for Android. |
Member
|
Fair enough! |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in Node's built-in
osmodule, where, in some cases, getting theos.cpus()value will return an empty Array. As a result, the testing process won't even start. To accommodate for this issue, I suggest adding a check foros.cpus()value.