Skip to content

Reverse order of arguments for operator.contains#9192

Merged
charliermarsh merged 1 commit intomainfrom
charlie/fix
Dec 18, 2023
Merged

Reverse order of arguments for operator.contains#9192
charliermarsh merged 1 commit intomainfrom
charlie/fix

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh commented Dec 18, 2023

Closes #9191.

@charliermarsh charliermarsh changed the title Reverse order of arguments for operator.contains Reverse order of arguments for operator.contains Dec 18, 2023
@charliermarsh charliermarsh added the bug Something isn't working label Dec 18, 2023
@charliermarsh charliermarsh merged commit be8f8e6 into main Dec 18, 2023
@charliermarsh charliermarsh deleted the charlie/fix branch December 18, 2023 19:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 18, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -2 violations, +0 -0 fixes in 2 projects; 39 projects unchanged)

apache/airflow (+0 -1 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview --select ALL

- kubernetes_tests/test_base.py:45:5: FURB118 Use `operator.contains` instead of defining a function

bokeh/bokeh (+0 -1 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview --select ALL

- src/bokeh/core/query.py:353:9: FURB118 [*] Use `operator.contains` instead of defining a lambda

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
FURB118 2 0 2 0 0

@miccal miccal mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FURB118 is incorrector for operator.contains. The operands are reversed!

1 participant

@charliermarsh