Update format.rs to display correct message for already formatted files#9153
Merged
charliermarsh merged 4 commits intoastral-sh:mainfrom Dec 18, 2023
Merged
Conversation
Contributor
|
| writeln!( | ||
| f, | ||
| "{} file{} {}, {} file{} left unchanged", | ||
| "{} file{} {}, {} file{} already formatted", |
Member
There was a problem hiding this comment.
I think we want to apply this change only in the event that we have FormatMode::Check | FormatMode::Diff -- do you mind tweaking, similar to "would be reformatted" below?
Contributor
Author
There was a problem hiding this comment.
Sorry, I don't understand: Check and Diff here are like the lower branch of the 'if'
Member
There was a problem hiding this comment.
@VictorGob - I pushed an update to illustrate what I meant. What do you think of this approach?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New messages for "format" mode.
Fixes #9132
Test Plan
I ran the tests specified in
CONTRIBUTING.mdcargo run -p ruff_cli -- check /path/to/some_files.py --no-cache cargo run -p ruff_cli -- format --check /path/to/some_files.py --no-cache cargo clippy --workspace --all-targets --all-features -- -D warnings RUFF_UPDATE_SCHEMA=1 cargo test pre-commit run --all-files --show-diff-on-failureNote: In case no files are detected, either correctly formatted, changed, or unchanged, it does not display a message. Wouldn't it be better to show some message in this case?